Code Review

I'm trying to set up a code review process for anything I release into
production on one of my servers. (we have a problem with being responsible
for hosting apps that we didn't develop)
The only things I could think of to put in the policy to check would be:
All Stored Procedures and Views will be:
1)Run through Query Analyzer to check for table scans and other
inefficiencies
2)Run through SQL Profiler
3)Reviewed to ensure developer did not use cursors and temp tables unless
absolutely necessary
Database Architecture will be examined prior to deployment.
Any suggestions?
Security issues
Ownership chains
Use of extended stored procs.
Linked server issues etc.
HTH
Rick Sawtell
MCT, MCSD, MCDBA
"Amanda" <Amanda@.discussions.microsoft.com> wrote in message
news:DF9E1B44-BE57-403B-B4ED-77F1F19C4B0A@.microsoft.com...
> I'm trying to set up a code review process for anything I release into
> production on one of my servers. (we have a problem with being
responsible
> for hosting apps that we didn't develop)
> The only things I could think of to put in the policy to check would be:
> All Stored Procedures and Views will be:
> 1) Run through Query Analyzer to check for table scans and other
> inefficiencies
> 2) Run through SQL Profiler
> 3) Reviewed to ensure developer did not use cursors and temp tables unless
> absolutely necessary
> Database Architecture will be examined prior to deployment.
> Any suggestions?
>
|||Amanda wrote:
> I'm trying to set up a code review process for anything I release into
> production on one of my servers. (we have a problem with being
> responsible for hosting apps that we didn't develop)
> The only things I could think of to put in the policy to check would
> be: All Stored Procedures and Views will be:
> 1) Run through Query Analyzer to check for table scans and other
> inefficiencies
> 2) Run through SQL Profiler
> 3) Reviewed to ensure developer did not use cursors and temp tables
> unless absolutely necessary
> Database Architecture will be examined prior to deployment.
> Any suggestions?
and...
- Test on a database with the same or similar data to the production
database
- Full regression testing from application while Profiler is running
- Clustered Index Scans in addition to Table Scans
David G.
|||Thanks guys!
I know what I want to look for but I couldn't articulate it.